fixed high cpu usage caused by spawning stupid amounts of script objects each tick

FFXIVClassic Map Server/Program.cs

@@ -18,7 +18,8 @@ namespace FFXIVClassic_Map_Server
         public static Logger Log;
         public static Server Server;
         public static Random Random;
-        public static DateTime Tick;
+        public static DateTime LastTick = DateTime.Now;
+        public static DateTime Tick = DateTime.Now;
 
         static void Main(string[] args)
         {

FFXIVClassic Map Server/WorldManager.cs

@@ -40,7 +40,7 @@ namespace FFXIVClassic_Map_Server
 
         private Server mServer;
 
-        private const int MILIS_LOOPTIME = 10;
+        private const int MILIS_LOOPTIME = 333;
         private Timer mZoneTimer;
 
         //Content Groups
@@ -1017,6 +1017,7 @@ namespace FFXIVClassic_Map_Server
                 Program.Tick = DateTime.Now;
                 foreach (Zone zone in zoneList.Values)
                     zone.Update(Program.Tick);
+                Program.LastTick = Program.Tick;
             }            
         }
 

FFXIVClassic Map Server/actors/area/Area.cs

@@ -616,6 +616,9 @@ namespace FFXIVClassic_Map_Server.Actors
             {
                 foreach (Actor a in mActorList.Values)
                     a.Update(tick);
+
+                var deltaTime = (tick - Program.LastTick).Milliseconds;
+                LuaEngine.GetInstance().CallLuaFunction(null, this, "onUpdate", true, deltaTime);
             }
         }
 

FFXIVClassic Map Server/actors/area/Zone.cs

@@ -166,9 +166,9 @@ namespace FFXIVClassic_Map_Server.actors.area
         public override void Update(DateTime tick)
         {
             // todo: again, this is retarded but debug stuff
-            var diffTime = tick - lastUpdate;
             base.Update(tick);
 
+            var diffTime = tick - lastUpdate;
             // arbitrary cap
             if (diffTime.Milliseconds >= 33)
             {

FFXIVClassic Map Server/actors/chara/npc/Npc.cs

@@ -396,8 +396,7 @@ namespace FFXIVClassic_Map_Server.Actors
 
         public override void Update(DateTime tick)
         {
-            var deltaTime = (tick - aiContainer.GetLatestUpdate()).Milliseconds;
+        
-            LuaEngine.GetInstance().CallLuaFunction(null, this, "onUpdate", true, deltaTime);         
         }
 
         //A party member list packet came, set the party

FFXIVClassic Map Server/lua/LuaEngine.cs

@@ -278,7 +278,7 @@ namespace FFXIVClassic_Map_Server.lua
 
         private void CallLuaFunctionNpc(Player player, Npc target, string funcName, bool optional, params object[] args)
         {
-            object[] args2 = new object[args.Length + (player == null ? 1:2)];
+            object[] args2 = new object[args.Length + (player == null ? 1 : 2)];
             Array.Copy(args, 0, args2, (player == null ? 1 : 2), args.Length);
             if (player != null)
             {
@@ -437,7 +437,8 @@ namespace FFXIVClassic_Map_Server.lua
                 Coroutine coroutine = mSleepingOnPlayerEvent[player.actorId];
                 mSleepingOnPlayerEvent.Remove(player.actorId);
 
-                try{
+                try
+                {
                     DynValue value = coroutine.Resume();
                     ResolveResume(null, coroutine, value);
                 }
@@ -465,7 +466,7 @@ namespace FFXIVClassic_Map_Server.lua
             {
                 GetInstance().AddWaitEventCoroutine(player, coroutine);
             }
-            else if (player != null && value.Tuple != null && value.Tuple.Length >= 1 && value.Tuple[0].String != null)
+            else if (value.Tuple != null && value.Tuple.Length >= 1 && value.Tuple[0].String != null)
             {
                 switch (value.Tuple[0].String)
                 {
@@ -620,9 +621,16 @@ namespace FFXIVClassic_Map_Server.lua
                     //script.Call(script.Globals["onTrigger"], LuaParam.ToArray());
 
                     // gm commands dont need to be coroutines?
-                    Coroutine coroutine = script.CreateCoroutine(script.Globals["onTrigger"]).Coroutine;
+                    try
-                    DynValue value = coroutine.Resume(LuaParam.ToArray());
+                    {
-                    LuaEngine.GetInstance().ResolveResume(player, coroutine, value);
+                        Coroutine coroutine = script.CreateCoroutine(script.Globals["onTrigger"]).Coroutine;
+                        DynValue value = coroutine.Resume(LuaParam.ToArray());
+                        GetInstance().ResolveResume(player, coroutine, value);
+                    }
+                    catch (Exception e)
+                    {
+                        Program.Log.Error("LuaEngine.RunGMCommand: {0} - {1}", path, e.Message);
+                    }
                     return;
                 }
             }
@@ -680,4 +688,3 @@ namespace FFXIVClassic_Map_Server.lua
 
     }
 }
- 

FFXIVClassic.sln

@@ -1,7 +1,7 @@
 
 Microsoft Visual Studio Solution File, Format Version 12.00
 # Visual Studio 15
-VisualStudioVersion = 15.0.26430.6
+VisualStudioVersion = 15.0.26430.15
 MinimumVisualStudioVersion = 10.0.40219.1
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "FFXIVClassic Map Server", "FFXIVClassic Map Server\FFXIVClassic Map Server.csproj", "{E8FA2784-D4B9-4711-8CC6-712A4B1CD54F}"
 	ProjectSection(ProjectDependencies) = postProject
@@ -23,6 +23,9 @@ EndProject
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Launcher Editor", "Launcher Editor\Launcher Editor.csproj", "{0FFA9D2F-41C6-443C-99B7-665702CF548F}"
 EndProject
 Global
+	GlobalSection(Performance) = preSolution
+		HasPerformanceSessions = true
+	EndGlobalSection
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
 		Debug|Any CPU = Debug|Any CPU
 		Release|Any CPU = Release|Any CPU