mirrors/sapphire
1
Fork 0
mirror of https://github.com/SapphireServer/Sapphire.git synced 2025-04-27 22:57:45 +00:00
Code Activity

Change size() > 0 checks to !empty()

Browse source
This commit is contained in:
Rushi 2024-06-21 11:31:58 +02:00
parent d8ffb010a3
commit 0ac79362cd
1 changed files with 5 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/world/Action/Action.cpp
View file

@ -592,15 +592,13 @@ void Action::Action::buildActionResults()
} }
// If we hit an enemy // If we hit an enemy
if( m_hitActors.size() > 0 && getHitChara()->getObjKind() != m_pSource->getObjKind() ) if( !m_hitActors.empty() && getHitChara()->getObjKind() != m_pSource->getObjKind() )
{ {
m_pSource->removeStatusEffectByFlag( Common::StatusEffectFlag::RemoveOnSuccessfulHit ); m_pSource->removeStatusEffectByFlag( Common::StatusEffectFlag::RemoveOnSuccessfulHit );
} }
handleJobAction(); handleJobAction();
handleStatusEffects();
if( m_lutEntry.statuses.caster.size() > 0 || m_lutEntry.statuses.target.size() > 0 )
handleStatusEffects();
m_actionResultBuilder->sendActionResults( m_hitActors ); m_actionResultBuilder->sendActionResults( m_hitActors );
@ -620,7 +618,7 @@ void Action::Action::handleStatusEffects()
return; return;
// handle caster statuses // handle caster statuses
if( m_lutEntry.statuses.caster.size() > 0 ) if( !m_lutEntry.statuses.caster.empty() )
{ {
for( auto& status : m_lutEntry.statuses.caster ) for( auto& status : m_lutEntry.statuses.caster )
{ {
@ -629,7 +627,7 @@ void Action::Action::handleStatusEffects()
} }
// handle hit actor statuses // handle hit actor statuses
if( m_lutEntry.statuses.target.size() > 0 && m_hitActors.size() > 0 ) if( !m_lutEntry.statuses.target.empty() && !m_hitActors.empty() )
{ {
for( auto& actor : m_hitActors ) for( auto& actor : m_hitActors )
{ {
@ -638,7 +636,7 @@ void Action::Action::handleStatusEffects()
pActionBuilder->applyStatusEffect( actor, status.id, status.duration, 0, std::move( status.modifiers ), status.flag, true ); pActionBuilder->applyStatusEffect( actor, status.id, status.duration, 0, std::move( status.modifiers ), status.flag, true );
} }
if( actor->getStatusEffectMap().size() > 0 ) if( !actor->getStatusEffectMap().empty() )
actor->onActionHostile( m_pSource ); actor->onActionHostile( m_pSource );
} }
} }