From 238a1c17a6b7a4a33008054e2a2f4ebee8183f97 Mon Sep 17 00:00:00 2001
From: ShelbyZ <user@shagman.codes>
Date: Tue, 17 Oct 2017 17:14:11 -0700
Subject: [PATCH] Potential Truncation - value over signed char

In PacketHandlers.cpp ~line453 - we are trying to insert a hex value
(128) x80 and will cause an underflow to -128.  Suggestion is to move to
unsigned char to capture the intended value.
---
 .../Server_Common/Network/PacketDef/Zone/ServerZoneDef.h        | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/servers/Server_Common/Network/PacketDef/Zone/ServerZoneDef.h b/src/servers/Server_Common/Network/PacketDef/Zone/ServerZoneDef.h
index 142975b4..4c2f75c7 100644
--- a/src/servers/Server_Common/Network/PacketDef/Zone/ServerZoneDef.h
+++ b/src/servers/Server_Common/Network/PacketDef/Zone/ServerZoneDef.h
@@ -81,7 +81,7 @@ struct FFXIVIpcPlayTime : FFXIVIpcBasePacket<Playtime>
 */
 struct PlayerEntry {
    uint64_t contentId;
-   char bytes[12];
+   unsigned char bytes[12];
    uint16_t zoneId;
    uint16_t zoneId1;
    char bytes1[8];