From 4c77868d1c580be5c06a04a7c1e7636bbdf828db Mon Sep 17 00:00:00 2001 From: Mordred Date: Tue, 20 Mar 2018 00:05:54 +0100 Subject: [PATCH] Simplified scripts a bit, a bit easier on the eyes --- src/servers/Scripts/CMakeLists.txt | 2 +- src/servers/Scripts/common/Aethernet.cpp | 6 +-- src/servers/Scripts/common/Aetheryte.cpp | 16 +++--- .../Scripts/common/CmnDefCutSceneReplay.cpp | 8 +-- src/servers/Scripts/common/CmnDefInnBed.cpp | 12 ++--- .../Scripts/common/CmnDefLinkShell.cpp | 4 +- .../Scripts/opening/OpeningGridania.cpp | 4 +- src/servers/Scripts/opening/OpeningLimsa.cpp | 4 +- src/servers/Scripts/opening/OpeningUldah.cpp | 4 +- src/servers/Scripts/quest/ManFst001.cpp | 15 +++--- src/servers/Scripts/quest/ManFst002.cpp | 50 ++++++++++--------- src/servers/Scripts/quest/ManFst004.cpp | 24 ++++----- src/servers/Scripts/quest/ManSea001.cpp | 20 ++++---- src/servers/Scripts/quest/ManSea002.cpp | 22 ++++---- src/servers/Scripts/quest/ManWil001.cpp | 14 +++--- src/servers/Scripts/quest/ManWil002.cpp | 22 ++++---- .../quest/subquest/gridania/SubFst001.cpp | 8 +-- .../quest/subquest/gridania/SubFst002.cpp | 8 +-- .../quest/subquest/gridania/SubFst010.cpp | 8 +-- .../quest/subquest/gridania/SubFst013.cpp | 18 +++---- src/servers/sapphire_zone/Event/Director.h | 14 +++--- .../sapphire_zone/Event/EventHandler.h | 10 +++- .../Network/Handlers/EventHandlers.cpp | 11 +++- src/tools/quest_parser/main.cpp | 7 ++- 24 files changed, 168 insertions(+), 143 deletions(-) diff --git a/src/servers/Scripts/CMakeLists.txt b/src/servers/Scripts/CMakeLists.txt index 5f938985..3d03ca0d 100644 --- a/src/servers/Scripts/CMakeLists.txt +++ b/src/servers/Scripts/CMakeLists.txt @@ -14,7 +14,7 @@ set(RUNTIME_OUTPUT_DIRECTORY "${SCRIPT_LIB_DIR}") file(GLOB children "${CMAKE_CURRENT_SOURCE_DIR}/*" ) foreach(_scriptDir ${children}) get_filename_component(_name "${_scriptDir}" NAME_WE) - if(IS_DIRECTORY ${_scriptDir} AND NOT ${_name} MATCHES "CMakeFiles") + if(IS_DIRECTORY ${_scriptDir} AND NOT ${_name} MATCHES "CMakeFiles" AND NOT ${_name} MATCHES "\\.dir$") message("discovered plugin lib: ${_scriptDir} (${_name})") file(GLOB_RECURSE SCRIPT_BUILD_FILES "${_scriptDir}/*.cpp") diff --git a/src/servers/Scripts/common/Aethernet.cpp b/src/servers/Scripts/common/Aethernet.cpp index b31f63a5..6d4bcc17 100644 --- a/src/servers/Scripts/common/Aethernet.cpp +++ b/src/servers/Scripts/common/Aethernet.cpp @@ -21,11 +21,11 @@ public: { if( player.isAetheryteRegistered( eventId & 0xFFFF ) ) { - player.eventPlay( eventId, 2, 0, []( Entity::Player& player, uint32_t eventId, uint16_t param1, uint16_t param2, uint16_t param3 ) + player.eventPlay( eventId, 2, 0, []( Entity::Player& player, const Event::SceneResult& result ) { - if( param1 == 256 ) + if( result.param1 == 256 ) { - player.teleport( param2, 2 ); + player.teleport( result.param2, 2 ); } } ); } diff --git a/src/servers/Scripts/common/Aetheryte.cpp b/src/servers/Scripts/common/Aetheryte.cpp index c5c9a399..95ba67db 100644 --- a/src/servers/Scripts/common/Aetheryte.cpp +++ b/src/servers/Scripts/common/Aetheryte.cpp @@ -23,20 +23,20 @@ public: { if( player.isAetheryteRegistered( eventId & 0xFFFF ) ) { - player.eventPlay( eventId, 0, 1, []( Entity::Player& player, uint32_t eventId, uint16_t param1, uint16_t param2, uint16_t param3 ) + player.eventPlay( eventId, 0, 1, []( Entity::Player& player, const Event::SceneResult& result ) { - if( param1 == 256 ) // set homepoint + if( result.param1 == 256 ) // set homepoint { - player.setHomepoint( eventId & 0xFFFF ); - player.sendQuestMessage( eventId, 2, 0xEA, 0, 0 ); + player.setHomepoint( result.eventId & 0xFFFF ); + player.sendQuestMessage( result.eventId, 2, 0xEA, 0, 0 ); } - else if( param1 == 512 ) // aethernet access + else if( result.param1 == 512 ) // aethernet access { - if( param2 == 4 ) + if( result.param2 == 4 ) { - player.teleport( param3, 2 ); + player.teleport( result.param3, 2 ); } - else if( param2 == 2 ) // register favored destination + else if( result.param2 == 2 ) // register favored destination { } diff --git a/src/servers/Scripts/common/CmnDefCutSceneReplay.cpp b/src/servers/Scripts/common/CmnDefCutSceneReplay.cpp index b701356b..ebe216b3 100644 --- a/src/servers/Scripts/common/CmnDefCutSceneReplay.cpp +++ b/src/servers/Scripts/common/CmnDefCutSceneReplay.cpp @@ -10,11 +10,11 @@ public: void Scene00000( Entity::Player& player ) { - auto callback = [ this ]( Entity::Player& player, uint32_t eventId, uint16_t param1, uint16_t param2, uint16_t param3 ) + auto callback = [ this ]( Entity::Player& player, const Event::SceneResult& result ) { - if( param2 != 0 ) + if( result.param2 != 0 ) { - Scene00001( player, param2 ); + Scene00001( player, result.param2 ); } }; @@ -23,7 +23,7 @@ public: void Scene00001( Entity::Player& player, uint16_t returnScene ) { - auto callback = []( Entity::Player& player, uint32_t eventId, uint16_t param1, uint16_t param2, uint16_t param3 ) + auto callback = []( Entity::Player& player, const Event::SceneResult& result ) { // todo: this is fucked }; diff --git a/src/servers/Scripts/common/CmnDefInnBed.cpp b/src/servers/Scripts/common/CmnDefInnBed.cpp index 40dc9d85..8a88d3fd 100644 --- a/src/servers/Scripts/common/CmnDefInnBed.cpp +++ b/src/servers/Scripts/common/CmnDefInnBed.cpp @@ -11,10 +11,10 @@ public: // menu void Scene00000( Entity::Player& player ) { - auto callback = [ this ]( Entity::Player& player, uint32_t eventId, uint16_t param1, uint16_t param2, uint16_t param3 ) + auto callback = [ this ]( Entity::Player& player, const Event::SceneResult& result ) { - if( param2 > 0 ) - Scene00001( player, param2 ); + if( result.param2 > 0 ) + Scene00001( player, result.param2 ); }; player.eventPlay( getId(), 0, 0x2000, 0, 1, callback ); @@ -23,9 +23,9 @@ public: // lay down void Scene00001( Entity::Player& player, uint16_t param ) { - auto callback = [ this ]( Entity::Player& player, uint32_t eventId, uint16_t param1, uint16_t param2, uint16_t param3 ) + auto callback = [ this ]( Entity::Player& player, const Event::SceneResult& result ) { - Scene00002( player, param2 ); + Scene00002( player, result.param2 ); }; player.eventPlay( getId(), 1, 0xF32E48F8, 0, 1, param, callback ); @@ -40,7 +40,7 @@ public: // wake up void Scene00100( Entity::Player& player ) { - auto callback = []( Entity::Player& player, uint32_t eventId, uint16_t param1, uint16_t param2, uint16_t param3 ) + auto callback = []( Entity::Player& player, const Event::SceneResult& result ) {}; player.eventPlay( getId(), 100, 0x800, 0, 0, callback ); diff --git a/src/servers/Scripts/common/CmnDefLinkShell.cpp b/src/servers/Scripts/common/CmnDefLinkShell.cpp index 541032ea..45c2a64b 100644 --- a/src/servers/Scripts/common/CmnDefLinkShell.cpp +++ b/src/servers/Scripts/common/CmnDefLinkShell.cpp @@ -14,9 +14,9 @@ public: void Scene00001( Entity::Player& player ) { - auto callback = [ this ]( Entity::Player& player, uint32_t eventId, uint16_t param1, uint16_t param2, uint16_t param3 ) + auto callback = [ this ]( Entity::Player& player, const Event::SceneResult& result ) { - switch( param2 ) + switch( result.param2 ) { case ACTION_CREATE: Scene00002( player ); diff --git a/src/servers/Scripts/opening/OpeningGridania.cpp b/src/servers/Scripts/opening/OpeningGridania.cpp index 0c218e02..0d13df54 100644 --- a/src/servers/Scripts/opening/OpeningGridania.cpp +++ b/src/servers/Scripts/opening/OpeningGridania.cpp @@ -28,7 +28,7 @@ private: void Scene00000( Entity::Player& player ) { - auto callback = [ this ]( Entity::Player& player, uint32_t eventId, uint16_t param1, uint16_t param2, uint16_t param3 ) + auto callback = [ this ]( Entity::Player& player, const Event::SceneResult& result ) { player.setOpeningSequence( 1 ); Scene00001( player ); @@ -56,7 +56,7 @@ private: void Scene00040( Entity::Player& player ) { - auto callback = [ this ]( Entity::Player& player, uint32_t eventId, uint16_t param1, uint16_t param2, uint16_t param3 ) + auto callback = [ this ]( Entity::Player& player, const Event::SceneResult& result ) { if( player.getOpeningSequence() == 2 ) { diff --git a/src/servers/Scripts/opening/OpeningLimsa.cpp b/src/servers/Scripts/opening/OpeningLimsa.cpp index 24a11421..8011377f 100644 --- a/src/servers/Scripts/opening/OpeningLimsa.cpp +++ b/src/servers/Scripts/opening/OpeningLimsa.cpp @@ -43,7 +43,7 @@ private: void Scene00000( Entity::Player& player ) { - auto callback = [ this ]( Entity::Player& player, uint32_t eventId, uint16_t param1, uint16_t param2, uint16_t param3 ) + auto callback = [ this ]( Entity::Player& player, const Event::SceneResult& result ) { player.setOpeningSequence( 1 ); Scene00001( player ); @@ -71,7 +71,7 @@ private: void Scene00040( Entity::Player& player ) { - auto callback = [ this ]( Entity::Player& player, uint32_t eventId, uint16_t param1, uint16_t param2, uint16_t param3 ) + auto callback = [ this ]( Entity::Player& player, const Event::SceneResult& result ) { if( player.getOpeningSequence() == 2 ) { diff --git a/src/servers/Scripts/opening/OpeningUldah.cpp b/src/servers/Scripts/opening/OpeningUldah.cpp index 2c66cffe..437b66c1 100644 --- a/src/servers/Scripts/opening/OpeningUldah.cpp +++ b/src/servers/Scripts/opening/OpeningUldah.cpp @@ -29,7 +29,7 @@ private: void Scene00000( Entity::Player& player ) { - auto callback = [ this ]( Entity::Player& player, uint32_t eventId, uint16_t param1, uint16_t param2, uint16_t param3 ) + auto callback = [ this ]( Entity::Player& player, const Event::SceneResult& result ) { player.setOpeningSequence( 1 ); Scene00001( player ); @@ -57,7 +57,7 @@ private: void Scene00040( Entity::Player& player ) { - auto callback = [ this ]( Entity::Player& player, uint32_t eventId, uint16_t param1, uint16_t param2, uint16_t param3 ) + auto callback = [ this ]( Entity::Player& player, const Event::SceneResult& result ) { if( player.getOpeningSequence() == 2 ) Scene00030( player ); diff --git a/src/servers/Scripts/quest/ManFst001.cpp b/src/servers/Scripts/quest/ManFst001.cpp index 8b813fe5..41907eaa 100644 --- a/src/servers/Scripts/quest/ManFst001.cpp +++ b/src/servers/Scripts/quest/ManFst001.cpp @@ -1,5 +1,6 @@ #include