From ab668bdc68f8bbaf40dad26f076fabd967e9f8a7 Mon Sep 17 00:00:00 2001 From: Alice Ogeda Date: Tue, 14 Dec 2021 16:06:23 -0300 Subject: [PATCH] more const correct; --- src/world/Manager/BlacklistMgr.cpp | 8 +++----- src/world/Manager/BlacklistMgr.h | 6 +++--- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/src/world/Manager/BlacklistMgr.cpp b/src/world/Manager/BlacklistMgr.cpp index 8d2f659d..d46d3a33 100644 --- a/src/world/Manager/BlacklistMgr.cpp +++ b/src/world/Manager/BlacklistMgr.cpp @@ -79,8 +79,6 @@ bool Sapphire::World::Manager::BlacklistMgr::onRemoveCharacter( Entity::Player& auto& server = Common::Service< Sapphire::World::WorldServer >::ref(); - uint32_t result = 0; - auto pTarget = server.getPlayer( targetName ); if( !pTarget ) { @@ -166,7 +164,7 @@ bool Sapphire::World::Manager::BlacklistMgr::onGetBlacklistPage( Entity::Player& return true; } -bool Sapphire::World::Manager::BlacklistMgr::isBlacklisted( Entity::Player& source, Entity::Player& target ) const +bool Sapphire::World::Manager::BlacklistMgr::isBlacklisted( Entity::Player& source, const Entity::Player& target ) const { return getEntryIndex( source, target.getCharacterId() ) != -1; } @@ -183,7 +181,7 @@ ptrdiff_t Sapphire::World::Manager::BlacklistMgr::getEntryIndex( Entity::Player& return sourceBlIt - std::begin( sourceBL ); } -void Sapphire::World::Manager::BlacklistMgr::sendAddResultPacket( Entity::Player& source, Entity::PlayerPtr pTarget, uint32_t result ) +void Sapphire::World::Manager::BlacklistMgr::sendAddResultPacket( Entity::Player& source, const Entity::PlayerPtr pTarget, uint32_t result ) { auto& server = Common::Service< Sapphire::World::WorldServer >::ref(); @@ -204,7 +202,7 @@ void Sapphire::World::Manager::BlacklistMgr::sendAddResultPacket( Entity::Player server.queueForPlayer( source.getCharacterId(), resultPacket ); } -void Sapphire::World::Manager::BlacklistMgr::sendRemoveResultPacket( Entity::Player& source, Entity::PlayerPtr pTarget, uint32_t result ) +void Sapphire::World::Manager::BlacklistMgr::sendRemoveResultPacket( Entity::Player& source, const Entity::PlayerPtr pTarget, uint32_t result ) { auto& server = Common::Service< Sapphire::World::WorldServer >::ref(); diff --git a/src/world/Manager/BlacklistMgr.h b/src/world/Manager/BlacklistMgr.h index af4e7169..13de63ea 100644 --- a/src/world/Manager/BlacklistMgr.h +++ b/src/world/Manager/BlacklistMgr.h @@ -16,12 +16,12 @@ namespace Sapphire::World::Manager bool onGetBlacklistPage( Entity::Player& source, uint8_t key, uint8_t nextIdx ); - bool isBlacklisted( Entity::Player& source, Entity::Player& target ) const; + bool isBlacklisted( Entity::Player& source, const Entity::Player& target ) const; private: ptrdiff_t getEntryIndex( Entity::Player& source, uint64_t characterId ) const; - void sendAddResultPacket( Entity::Player& source, Entity::PlayerPtr pTarget, uint32_t result ); - void sendRemoveResultPacket( Entity::Player& source, Entity::PlayerPtr pTarget, uint32_t result ); + void sendAddResultPacket( Entity::Player& source, const Entity::PlayerPtr pTarget, uint32_t result ); + void sendRemoveResultPacket( Entity::Player& source, const Entity::PlayerPtr pTarget, uint32_t result ); }; }