From cb441475647251b7e140f437fabd6c26baa10166 Mon Sep 17 00:00:00 2001 From: Adam Date: Thu, 15 Feb 2018 19:27:44 +1100 Subject: [PATCH 1/2] fix compile warning --- src/servers/sapphire_zone/Actor/PlayerSql.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/servers/sapphire_zone/Actor/PlayerSql.cpp b/src/servers/sapphire_zone/Actor/PlayerSql.cpp index b3b63f1f..8e72f3cd 100644 --- a/src/servers/sapphire_zone/Actor/PlayerSql.cpp +++ b/src/servers/sapphire_zone/Actor/PlayerSql.cpp @@ -313,7 +313,8 @@ bool Core::Entity::Player::loadSearchInfo() m_searchSelectClass = res->getUInt8( 1 ); m_searchSelectRegion = res->getUInt8( 2 ); - sprintf( m_searchMessage, res->getString( 3 ).c_str() ); + auto searchMessage = res->getString( 3 ); + std::copy( searchMessage.begin(), searchMessage.end(), m_searchMessage ); return true; } From 48a1fd502a05a6f2eb60b952987bbd647679d4c6 Mon Sep 17 00:00:00 2001 From: Adam Date: Thu, 15 Feb 2018 19:44:54 +1100 Subject: [PATCH 2/2] add todo note --- src/servers/sapphire_zone/Actor/PlayerSql.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/servers/sapphire_zone/Actor/PlayerSql.cpp b/src/servers/sapphire_zone/Actor/PlayerSql.cpp index 8e72f3cd..b1522720 100644 --- a/src/servers/sapphire_zone/Actor/PlayerSql.cpp +++ b/src/servers/sapphire_zone/Actor/PlayerSql.cpp @@ -313,6 +313,8 @@ bool Core::Entity::Player::loadSearchInfo() m_searchSelectClass = res->getUInt8( 1 ); m_searchSelectRegion = res->getUInt8( 2 ); + + // todo: internally use an std::string instead of a char[] auto searchMessage = res->getString( 3 ); std::copy( searchMessage.begin(), searchMessage.end(), m_searchMessage );