From 633d019436b7f4e62c91d704ec1f83f549928b46 Mon Sep 17 00:00:00 2001
From: Dantestyle <null-fox@hotmail.it>
Date: Sun, 13 May 2018 04:29:29 +0200
Subject: [PATCH 1/5] ManSea001 now work properly

---
 src/servers/Scripts/quest/ManSea001.cpp | 79 +++++++++++++------------
 1 file changed, 40 insertions(+), 39 deletions(-)

diff --git a/src/servers/Scripts/quest/ManSea001.cpp b/src/servers/Scripts/quest/ManSea001.cpp
index 79d56ecc..fefea24e 100644
--- a/src/servers/Scripts/quest/ManSea001.cpp
+++ b/src/servers/Scripts/quest/ManSea001.cpp
@@ -1,13 +1,18 @@
 #include <Script/NativeScriptApi.h>
 #include <Actor/Player.h>
 #include "Event/EventHelper.h"
-#include "../ScriptObject.h"
+#include <ScriptObject.h>
+
+// Quest Script: ManSea001_00107
+// Quest Name: Coming to Limsa Lominsa
+// Quest ID: 65643
+// Start NPC: 1001028
+// End NPC: 1002697
 
 class ManSea001 : public EventScript
 {
 private:
-   // Steps in this quest ( 0 is before accepting,
-   // 1 is first, 255 means ready for turning it in
+
    static constexpr auto SEQ_0 = 0;
    static constexpr auto SEQ_1 = 1;
    static constexpr auto SEQ_FINISH = 255;
@@ -27,102 +32,98 @@ private:
 
    void Scene00000( Entity::Player& player )
    {
-      auto callback = [this]( Entity::Player& player, const Event::SceneResult& result )
+      player.playScene( m_id, 0, 8192,
+         [&]( Entity::Player& player, const Event::SceneResult& result )
       {
-         if( result.param2 == 1 )
+         if ( result.param2 == 1 )
          {
             player.setOpeningSequence( 2 );
             Scene00001( player );
          }
-      };
-
-      player.playScene( getId(), 0, HIDE_HOTBAR, 0, 0, callback );
+      } );
    }
 
    void Scene00001( Entity::Player& player )
    {
-      player.playSceneChain( getId(), 1, DISABLE_SKIP | HIDE_HOTBAR | SET_BASE, bindScene( &ManSea001::Scene00002 ) );
+      player.playSceneChain( m_id, 1, DISABLE_SKIP | HIDE_HOTBAR | SET_BASE, bindScene( &ManSea001::Scene00002 ) );
    }
 
    void Scene00002( Entity::Player& player )
    {
-      player.playSceneChain( getId(), 2, NONE, bindScene( &ManSea001::Scene00003 ) );
+      player.updateQuest( m_id, 1 );
+      player.playSceneChain( m_id, 2, NONE, bindScene( &ManSea001::Scene00003 ) );
    }
 
    void Scene00003( Entity::Player& player )
    {
-      auto callback = [this]( Entity::Player& player, const Event::SceneResult& result )
-      {
-         player.playScene( OPENING_EVENT_HANDLER, 0x1E, HIDE_HOTBAR | NO_DEFAULT_CAMERA, 1, 0 );
-      };
-
-      player.playScene( getId(), 3, NONE, 0, 0, callback );
+      player.playScene( OPENING_EVENT_HANDLER, 0x1E, HIDE_HOTBAR | NO_DEFAULT_CAMERA, 1, 0 );
    }
 
    void Scene00004( Entity::Player& player )
    {
-      player.playScene( getId(), 4, NONE, 0, 0 );
+      player.playScene( m_id, 4, NONE, 0, 0 );
    }
 
    void Scene00005( Entity::Player& player )
    {
-      player.playSceneChain( getId(), 5, HIDE_HOTBAR, bindScene( &ManSea001::Scene00006 ) );
+      player.playSceneChain( m_id, 5, HIDE_HOTBAR, bindScene( &ManSea001::Scene00006 ) );
    }
 
    void Scene00006( Entity::Player& player )
    {
-      auto callback = [this]( Entity::Player& player, const Event::SceneResult& result )
+      player.playScene( m_id, 6, INVIS_OTHER_PC,
+         [&]( Entity::Player& player, const Event::SceneResult& result )
       {
-         player.updateQuest( getId(), SEQ_FINISH );
-         player.prepareZoning( player.getZoneId(), true, 1, 0 );
-         player.changePosition( 9, 40, 14, 2 );
-      };
-
-      player.playScene( getId(), 6, INVIS_OTHER_PC, 0, 0, callback );
+         if ( result.param2 == 1 )
+         {
+            player.updateQuest( m_id, SEQ_FINISH );
+            player.prepareZoning( player.getZoneId(), true, 1, 0 );
+            player.changePosition( 9, 40, 14, 2 );
+         }
+      } );
    }
 
    void Scene00007( Entity::Player& player )
    {
-      player.playScene( getId(), 7, NONE, 0, 0 );
+      player.playScene( m_id, 7, NONE, 0, 0 );
    }
 
    void Scene00008( Entity::Player& player )
    {
-      player.playScene( getId(), 8, NONE, 0, 0 );
+      player.playScene( m_id, 8, NONE, 0, 0 );
    }
 
    void Scene00009( Entity::Player& player )
    {
-      player.playScene( getId(), 9, NONE, 0, 0 );
+      player.playScene( m_id, 9, NONE, 0, 0 );
    }
 
    void Scene00010( Entity::Player& player )
    {
-      player.playScene( getId(), 10, NONE, 0, 0 );
+      player.playScene( m_id, 10, NONE, 0, 0 );
    }
 
    void Scene00011( Entity::Player& player )
    {
-      player.playSceneChain( getId(), 11, 0x2c02, 0, 0, bindScene( &ManSea001::Scene00012 ) );
+      player.playSceneChain( m_id, 11, 0x2c02, 0, 0, bindScene( &ManSea001::Scene00012 ) );
    }
 
    void Scene00012( Entity::Player& player )
    {
-      auto callback = [this]( Entity::Player& player, const Event::SceneResult& result )
+      player.playScene( m_id, 12, INVIS_OTHER_PC,
+         [&]( Entity::Player& player, const Event::SceneResult& result )
       {
-         if( result.param2 == 1 ) // finish quest
+         if ( result.param2 == 1 ) // finish quest
          {
-            if( player.giveQuestRewards( getId(), 0 ) )
-               player.finishQuest( getId());
+            if ( player.giveQuestRewards( m_id, 0 ) )
+               player.finishQuest( m_id );
          }
-      };
-
-      player.playScene( getId(), 12, INVIS_OTHER_PC, 0, 0, callback );
+      } );
    }
 
    void Scene00013( Entity::Player& player )
    {
-      player.playScene( getId(), 13, NONE, 0, 0 );
+      player.playScene( m_id, 13, NONE, 0, 0 );
    }
 
 public:
@@ -137,7 +138,7 @@ public:
          Scene00000( player );
       else if( actor == ACTOR1 )
          Scene00005( player );
-      else if( actor == ACTOR2 )
+     else if( actor == ACTOR2 )
          Scene00011( player );
    }
 };
\ No newline at end of file

From 50344e2520d1de7771a7f83a9e166ebfe72e4840 Mon Sep 17 00:00:00 2001
From: Dantestyle <null-fox@hotmail.it>
Date: Sun, 13 May 2018 04:39:35 +0200
Subject: [PATCH 2/5] typo error 1

---
 src/servers/Scripts/quest/ManSea001.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/servers/Scripts/quest/ManSea001.cpp b/src/servers/Scripts/quest/ManSea001.cpp
index fefea24e..f3b92f07 100644
--- a/src/servers/Scripts/quest/ManSea001.cpp
+++ b/src/servers/Scripts/quest/ManSea001.cpp
@@ -138,7 +138,7 @@ public:
          Scene00000( player );
       else if( actor == ACTOR1 )
          Scene00005( player );
-     else if( actor == ACTOR2 )
+      else if( actor == ACTOR2 )
          Scene00011( player );
    }
 };
\ No newline at end of file

From f62d09b0518ba7092d543551a6ad9d2784347d77 Mon Sep 17 00:00:00 2001
From: Dantestyle <null-fox@hotmail.it>
Date: Mon, 14 May 2018 04:35:40 +0200
Subject: [PATCH 3/5] typo errors 2

---
 src/servers/Scripts/quest/ManSea001.cpp | 44 ++++++++++++++-----------
 1 file changed, 24 insertions(+), 20 deletions(-)

diff --git a/src/servers/Scripts/quest/ManSea001.cpp b/src/servers/Scripts/quest/ManSea001.cpp
index f3b92f07..b35a28ae 100644
--- a/src/servers/Scripts/quest/ManSea001.cpp
+++ b/src/servers/Scripts/quest/ManSea001.cpp
@@ -32,10 +32,10 @@ private:
 
    void Scene00000( Entity::Player& player )
    {
-      player.playScene( m_id, 0, 8192,
+      player.playScene( getId(), 0, 8192,
          [&]( Entity::Player& player, const Event::SceneResult& result )
       {
-         if ( result.param2 == 1 )
+         if( result.param2 == 1 )
          {
             player.setOpeningSequence( 2 );
             Scene00001( player );
@@ -45,38 +45,42 @@ private:
 
    void Scene00001( Entity::Player& player )
    {
-      player.playSceneChain( m_id, 1, DISABLE_SKIP | HIDE_HOTBAR | SET_BASE, bindScene( &ManSea001::Scene00002 ) );
+      player.playSceneChain( getId(), 1, DISABLE_SKIP | HIDE_HOTBAR | SET_BASE, bindScene( &ManSea001::Scene00002 ) );
    }
 
    void Scene00002( Entity::Player& player )
    {
-      player.updateQuest( m_id, 1 );
-      player.playSceneChain( m_id, 2, NONE, bindScene( &ManSea001::Scene00003 ) );
+      player.updateQuest( getId(), 1 );
+      player.playSceneChain( getId(), 2, NONE, bindScene( &ManSea001::Scene00003 ) );
    }
 
    void Scene00003( Entity::Player& player )
    {
-      player.playScene( OPENING_EVENT_HANDLER, 0x1E, HIDE_HOTBAR | NO_DEFAULT_CAMERA, 1, 0 );
+      player.playScene( getId(), 3, NONE,
+         [&]( Entity::Player& player, const Event::SceneResult& result )
+      {
+         player.playScene( OPENING_EVENT_HANDLER, 0x1E, HIDE_HOTBAR | NO_DEFAULT_CAMERA, 1, 0 );
+      } );
    }
 
    void Scene00004( Entity::Player& player )
    {
-      player.playScene( m_id, 4, NONE, 0, 0 );
+      player.playScene( getId(), 4, NONE, 0, 0 );
    }
 
    void Scene00005( Entity::Player& player )
    {
-      player.playSceneChain( m_id, 5, HIDE_HOTBAR, bindScene( &ManSea001::Scene00006 ) );
+      player.playSceneChain( getId(), 5, HIDE_HOTBAR, bindScene( &ManSea001::Scene00006 ) );
    }
 
    void Scene00006( Entity::Player& player )
    {
-      player.playScene( m_id, 6, INVIS_OTHER_PC,
+      player.playScene( getId(), 6, INVIS_OTHER_PC,
          [&]( Entity::Player& player, const Event::SceneResult& result )
       {
-         if ( result.param2 == 1 )
+         if( result.param2 == 1 )
          {
-            player.updateQuest( m_id, SEQ_FINISH );
+            player.updateQuest( getId(), SEQ_FINISH );
             player.prepareZoning( player.getZoneId(), true, 1, 0 );
             player.changePosition( 9, 40, 14, 2 );
          }
@@ -85,37 +89,37 @@ private:
 
    void Scene00007( Entity::Player& player )
    {
-      player.playScene( m_id, 7, NONE, 0, 0 );
+      player.playScene( getId(), 7, NONE, 0, 0 );
    }
 
    void Scene00008( Entity::Player& player )
    {
-      player.playScene( m_id, 8, NONE, 0, 0 );
+      player.playScene( getId(), 8, NONE, 0, 0 );
    }
 
    void Scene00009( Entity::Player& player )
    {
-      player.playScene( m_id, 9, NONE, 0, 0 );
+      player.playScene( getId(), 9, NONE, 0, 0 );
    }
 
    void Scene00010( Entity::Player& player )
    {
-      player.playScene( m_id, 10, NONE, 0, 0 );
+      player.playScene( getId(), 10, NONE, 0, 0 );
    }
 
    void Scene00011( Entity::Player& player )
    {
-      player.playSceneChain( m_id, 11, 0x2c02, 0, 0, bindScene( &ManSea001::Scene00012 ) );
+      player.playSceneChain( getId(), 11, 0x2c02, 0, 0, bindScene( &ManSea001::Scene00012 ) );
    }
 
    void Scene00012( Entity::Player& player )
    {
-      player.playScene( m_id, 12, INVIS_OTHER_PC,
+      player.playScene( getId(), 12, INVIS_OTHER_PC,
          [&]( Entity::Player& player, const Event::SceneResult& result )
       {
-         if ( result.param2 == 1 ) // finish quest
+         if( result.param2 == 1 ) // finish quest
          {
-            if ( player.giveQuestRewards( m_id, 0 ) )
+            if( player.giveQuestRewards( getId(), 0 ) )
                player.finishQuest( m_id );
          }
       } );
@@ -123,7 +127,7 @@ private:
 
    void Scene00013( Entity::Player& player )
    {
-      player.playScene( m_id, 13, NONE, 0, 0 );
+      player.playScene( getId(), 13, NONE, 0, 0 );
    }
 
 public:

From 0cba5299ef19063e4221ebb4dc2184c2e569aa4a Mon Sep 17 00:00:00 2001
From: Dantestyle <null-fox@hotmail.it>
Date: Mon, 14 May 2018 05:50:49 +0200
Subject: [PATCH 4/5] typo error again 3

---
 src/servers/Scripts/quest/ManSea001.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/servers/Scripts/quest/ManSea001.cpp b/src/servers/Scripts/quest/ManSea001.cpp
index b35a28ae..006ba217 100644
--- a/src/servers/Scripts/quest/ManSea001.cpp
+++ b/src/servers/Scripts/quest/ManSea001.cpp
@@ -119,8 +119,8 @@ private:
       {
          if( result.param2 == 1 ) // finish quest
          {
-            if( player.giveQuestRewards( getId(), 0 ) )
-               player.finishQuest( m_id );
+            if (player.giveQuestRewards( getId(), 0))
+               player.finishQuest( getId() );
          }
       } );
    }

From fc5bdf9dd97ae578976730624d018d312275c455 Mon Sep 17 00:00:00 2001
From: Dantestyle <null-fox@hotmail.it>
Date: Mon, 14 May 2018 06:03:17 +0200
Subject: [PATCH 5/5] typo...

---
 src/servers/Scripts/quest/ManSea001.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/servers/Scripts/quest/ManSea001.cpp b/src/servers/Scripts/quest/ManSea001.cpp
index 006ba217..7f0a8840 100644
--- a/src/servers/Scripts/quest/ManSea001.cpp
+++ b/src/servers/Scripts/quest/ManSea001.cpp
@@ -119,7 +119,7 @@ private:
       {
          if( result.param2 == 1 ) // finish quest
          {
-            if (player.giveQuestRewards( getId(), 0))
+            if(player.giveQuestRewards( getId(), 0 ) )
                player.finishQuest( getId() );
          }
       } );