From 0a34dd676eddbd02c0c4bd1f9e453523ccad9994 Mon Sep 17 00:00:00 2001
From: Joshua Goins <josh@redstrate.com>
Date: Tue, 1 Mar 2022 16:58:47 -0500
Subject: [PATCH] Attempt to use system libraries (properly this time)

---
 CMakeLists.txt          | 20 +++++++++++++++++---
 external/CMakeLists.txt | 12 ++----------
 src/launchercore.cpp    |  2 +-
 src/launcherwindow.cpp  |  2 +-
 src/main.cpp            |  2 +-
 5 files changed, 22 insertions(+), 16 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 4d6df2a..09ee480 100755
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -15,7 +15,6 @@ if(ENABLE_WATCHDOG)
     pkg_search_module(LEPTONICA REQUIRED lept)
 endif()
 
-add_subdirectory(external)
 
 set(SRC
         src/main.cpp
@@ -34,8 +33,24 @@ set(SRC
         src/gamescopesettingswindow.cpp
         include/gamescopesettingswindow.h)
 
+find_package(Qt5Keychain)
+if(TARGET Qt5Keychain::Qt5Keychain)
+    message("Using system library for Qt5 Keychain")
+
+    set(LIBRARIES Qt5Keychain::Qt5Keychain ${LIBRARIES})
+endif()
+
+find_package(QuaZip-Qt5)
+if(TARGET QuaZip::QuaZip)
+    message("Using system library for Quazip")
+
+    set(LIBRARIES QuaZip::QuaZip ${LIBRARIES})
+endif()
+
+add_subdirectory(external)
+
 set(LIBRARIES
-        Qt5::Core Qt5::Widgets Qt5::Network ${KEYCHAIN_LIBRARIES} ${QUAZIP_LIBRARIES})
+        Qt5::Core Qt5::Widgets Qt5::Network Qt5Keychain::Qt5Keychain ${LIBRARIES})
 
 if(ENABLE_WATCHDOG)
     set(LIBRARIES ${LIBRARIES} ${TESSERACT_LIBRARIES} ${LEPTONICA_LIBRARIES})
@@ -58,7 +73,6 @@ add_executable(astra ${SRC})
 
 target_link_libraries(astra PUBLIC ${LIBRARIES})
 
-# disgusting, thanks qtkeychain and quazip
 target_include_directories(astra
         PUBLIC
         ${CMAKE_CURRENT_SOURCE_DIR}/include
diff --git a/external/CMakeLists.txt b/external/CMakeLists.txt
index ebcbe3e..11f8f95 100644
--- a/external/CMakeLists.txt
+++ b/external/CMakeLists.txt
@@ -1,7 +1,5 @@
 include(FetchContent)
 
-find_package(QtKeychain-Qt5)
-
 if(NOT TARGET Qt5Keychain::Qt5Keychain)
     FetchContent_Declare(
             qtkeychain
@@ -14,17 +12,13 @@ if(NOT TARGET Qt5Keychain::Qt5Keychain)
 
     FetchContent_MakeAvailable(qtkeychain)
 
-    set(KEYCHAIN_LIBRARIES qt5keychain PARENT_SCOPE)
+    set(LIBRARIES qt5keychain ${LIBRARIES} PARENT_SCOPE)
     set(KEYCHAIN_INCLUDE_DIRS
             ${CMAKE_BINARY_DIR}/_deps/qtkeychain-src
             ${CMAKE_BINARY_DIR}/_deps/qtkeychain-build PARENT_SCOPE)
-else()
-    set(KEYCHAIN_LIBRARIES Qt5Keychain::Qt5Keychain PARENT_SCOPE)
 endif()
 
 
-#quazip
-find_package(QuaZip-Qt5)
 if(NOT TARGET QuaZip::QuaZip)
     FetchContent_Declare(
             quazip
@@ -33,8 +27,6 @@ if(NOT TARGET QuaZip::QuaZip)
     )
     FetchContent_MakeAvailable(quazip)
 
-    set(QUAZIP_LIBRARIES QuaZip PARENT_SCOPE)
+    set(LIBRARIES QuaZip ${LIBRARIES} PARENT_SCOPE)
     set(QUAZIP_INCLUDE_DIRS ${CMAKE_BINARY_DIR}/_deps/quazip-src/quazip PARENT_SCOPE)
-else()
-    set(QUAZIP_LIBRARIES QuaZip::QuaZip PARENT_SCOPE)
 endif()
diff --git a/src/launchercore.cpp b/src/launchercore.cpp
index 118553c..d7500fd 100755
--- a/src/launchercore.cpp
+++ b/src/launchercore.cpp
@@ -11,7 +11,7 @@
 #include <QJsonObject>
 #include <QJsonDocument>
 #include <QCheckBox>
-#include <keychain.h>
+#include <qt5keychain/keychain.h>
 #include <QMessageBox>
 #include <QMenuBar>
 #include <QCoreApplication>
diff --git a/src/launcherwindow.cpp b/src/launcherwindow.cpp
index 1044f59..3b42b3a 100644
--- a/src/launcherwindow.cpp
+++ b/src/launcherwindow.cpp
@@ -1,7 +1,7 @@
 #include "launcherwindow.h"
 
 #include <QMenuBar>
-#include <keychain.h>
+#include <qt5keychain/keychain.h>
 #include <QFormLayout>
 #include <QApplication>
 #include <QDesktopServices>
diff --git a/src/main.cpp b/src/main.cpp
index 8b8ad9f..0c25207 100755
--- a/src/main.cpp
+++ b/src/main.cpp
@@ -3,7 +3,7 @@
 
 #include <QApplication>
 #include <QCommandLineParser>
-#include <keychain.h>
+#include <qt5keychain/keychain.h>
 
 #include "sapphirelauncher.h"
 #include "squareboot.h"