redstrate/astra
1
Fork 0
mirror of https://github.com/redstrate/Astra.git synced 2025-04-20 11:47:46 +00:00
Code Activity

Async WritePassword hates me

Browse source
This commit is contained in:
Joshua Goins 2023-12-20 21:52:43 -05:00
parent 322885e8e8
commit 167a94a2fe
2 changed files with 7 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
launcher/include/account.h
View file

@ -106,7 +106,7 @@ private:
/*
* Sets a value in the keychain. This function is asynchronous.
*/
QCoro::Task<> setKeychainValue(const QString &key, const QString &value);
void setKeychainValue(const QString &key, const QString &value);
/*
* Retrieves a value from the keychain. This function is synchronous.

10
launcher/src/account.cpp
View file

@ -269,7 +269,7 @@ void Account::fetchAvatar()
}
}
QCoro::Task<> Account::setKeychainValue(const QString &key, const QString &value)
void Account::setKeychainValue(const QString &key, const QString &value)
{
auto job = new QKeychain::WritePasswordJob(QStringLiteral("Astra"), this);
job->setTextData(value);
@ -281,13 +281,11 @@ QCoro::Task<> Account::setKeychainValue(const QString &key, const QString &value
job->setInsecureFallback(m_launcher.isSteamDeck()); // The Steam Deck does not have secrets provider in Game Mode
job->start();
co_await qCoro(job, &QKeychain::WritePasswordJob::finished);
connect(job, &QKeychain::WritePasswordJob::finished, this, [job] {
if (job->error() != QKeychain::NoError) {
qWarning(ASTRA_LOG) << "Error when writing" << key << job->errorString();
qWarning(ASTRA_LOG) << "Error when writing" << job->errorString();
}
co_return;
});
}
QCoro::Task<QString> Account::getKeychainValue(const QString &key)