Improve look and spacing of login, accounts, and profiles pages

launcher/include/accountmanager.h

@@ -37,7 +37,8 @@ public:
     Q_INVOKABLE bool canDelete(Account *account) const;
     Q_INVOKABLE void deleteAccount(Account *account);
 
-    Q_INVOKABLE bool hasAnyAccounts() const;
+    Q_INVOKABLE [[nodiscard]] bool hasAnyAccounts() const;
+    Q_INVOKABLE [[nodiscard]] int numAccounts() const;
 
 private:
     void insertAccount(Account *account);

launcher/include/profilemanager.h

@@ -37,6 +37,7 @@ public:
     Q_INVOKABLE void deleteProfile(Profile *profile);
 
     [[nodiscard]] QVector<Profile *> profiles() const;
+    [[nodiscard]] Q_INVOKABLE int numProfiles() const;
 
     Q_INVOKABLE bool canDelete(Profile *account) const;
 

launcher/src/accountmanager.cpp

@@ -116,3 +116,8 @@ bool AccountManager::hasAnyAccounts() const
 {
     return !m_accounts.empty();
 }
+
+int AccountManager::numAccounts() const
+{
+    return m_accounts.count();
+}

launcher/src/profilemanager.cpp

@@ -158,3 +158,8 @@ bool ProfileManager::hasAnyExistingInstallations() const
 
     return false;
 }
+
+int ProfileManager::numProfiles() const
+{
+    return m_profiles.count();
+}

launcher/ui/Components/FormFolderDelegate.qml

@@ -20,7 +20,11 @@ FormCard.AbstractFormDelegate {
     onClicked: dialog.open()
 
     contentItem: RowLayout {
+        spacing: Kirigami.Units.mediumSpacing
+
         ColumnLayout {
+            spacing: Kirigami.Units.mediumSpacing
+
             Layout.fillWidth: true
 
             QQC2.Label {

launcher/ui/Pages/LoginPage.qml

@@ -99,7 +99,11 @@ QQC2.Control {
     contentItem: ColumnLayout {
         width: parent.width
 
+        spacing: Kirigami.Units.largeSpacing
+
         FormCard.FormCard {
+            maximumWidth: Kirigami.Units.gridUnit * 25
+
             Layout.fillWidth: true
 
             FormCard.FormButtonDelegate {
@@ -132,6 +136,8 @@ QQC2.Control {
         }
 
         FormCard.FormCard {
+            maximumWidth: Kirigami.Units.gridUnit * 25
+
             Layout.fillWidth: true
 
             FormCard.FormButtonDelegate {
@@ -255,6 +261,8 @@ QQC2.Control {
         }
 
         FormCard.FormCard {
+            maximumWidth: Kirigami.Units.gridUnit * 25
+
             Layout.fillWidth: true
 
             FormCard.FormButtonDelegate {

launcher/ui/Pages/MainPage.qml

@@ -24,6 +24,8 @@ Kirigami.Page {
     RowLayout {
         anchors.fill: parent
 
+        spacing: Kirigami.Units.largeSpacing
+
         Loader {
             active: LauncherCore.showNews
 
@@ -44,7 +46,7 @@ Kirigami.Page {
             id: loginPage
 
             Layout.alignment: Qt.AlignTop | Qt.AlignHCenter
-            Layout.minimumWidth: LauncherCore.showNews ? Kirigami.Units.gridUnit * 25 : 0
+            Layout.minimumWidth: LauncherCore.showNews ? Kirigami.Units.gridUnit * 26 : 0
             Layout.fillWidth: !LauncherCore.showNews
         }
     }

launcher/ui/Pages/NewsPage.qml

@@ -50,6 +50,8 @@ QQC2.Control {
 
         readonly property real maximumWidth: Kirigami.Units.gridUnit * 50
 
+        spacing: Kirigami.Units.largeSpacing
+
         Image {
             id: bannerImage
 

launcher/ui/Settings/AccountsPage.qml

@@ -23,9 +23,13 @@ FormCard.FormCardPage {
         Repeater {
             model: LauncherCore.accountManager
 
-            FormCard.FormButtonDelegate {
+            ColumnLayout {
                 required property var account
+                required property int index
 
+                spacing: 0
+
+                FormCard.FormButtonDelegate {
                     text: account.name
 
                     leading: Components.Avatar {
@@ -38,11 +42,17 @@ FormCard.FormCardPage {
                         account: account
                     })
                 }
-        }
 
                 FormCard.FormDelegateSeparator {
-            below: addSquareEnixButton
+                    visible: index + 1 < LauncherCore.accountManager.numAccounts()
                 }
+            }
+        }
+    }
+
+    FormCard.FormCard {
+        Layout.fillWidth: true
+        Layout.topMargin: Kirigami.Units.largeSpacing
 
         FormCard.FormButtonDelegate {
             id: addSquareEnixButton

launcher/ui/Settings/ProfilesPage.qml

@@ -22,19 +22,31 @@ FormCard.FormCardPage {
         Repeater {
             model: LauncherCore.profileManager
 
-            FormCard.FormButtonDelegate {
+            ColumnLayout {
                 required property var profile
+                required property int index
+
+                spacing: 0
+
+                FormCard.FormButtonDelegate {
+                    id: buttonDelegate
 
                     text: profile.name
                     onClicked: page.Window.window.pageStack.layers.push(Qt.createComponent("zone.xiv.astra", "ProfileSettings"), {
                         profile: profile
                     })
                 }
-        }
 
                 FormCard.FormDelegateSeparator {
-            below: addProfileButton
+                    visible: index + 1 < LauncherCore.profileManager.numProfiles()
                 }
+            }
+        }
+    }
+
+    FormCard.FormCard {
+        Layout.fillWidth: true
+        Layout.topMargin: Kirigami.Units.largeSpacing
 
         FormCard.FormButtonDelegate {
             id: addProfileButton