From d09f2d2418d566746735238522807be49c156afb Mon Sep 17 00:00:00 2001 From: Joshua Goins Date: Mon, 5 May 2025 15:51:01 -0400 Subject: [PATCH] Hide Dalamud settings unless it's enabled Otherwise, it just creates visual noise on the settings page if you don't find it useful. --- launcher/ui/Settings/ProfileSettings.qml | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/launcher/ui/Settings/ProfileSettings.qml b/launcher/ui/Settings/ProfileSettings.qml index db59af6..012e0fc 100644 --- a/launcher/ui/Settings/ProfileSettings.qml +++ b/launcher/ui/Settings/ProfileSettings.qml @@ -217,6 +217,7 @@ FormCard.FormCardPage { FormCard.FormDelegateSeparator { above: enableDalamudDelegate below: dalamudChannelDelegate + visible: page.profile.config.dalamudEnabled } FormCard.FormComboBoxDelegate { @@ -230,18 +231,18 @@ FormCard.FormCardPage { page.profile.config.save(); } enabled: page.profile.config.dalamudEnabled + visible: page.profile.config.dalamudEnabled } FormCard.FormDelegateSeparator { above: dalamudChannelDelegate below: dalamudInjectDelegate - visible: LauncherCore.config.showDevTools + visible: LauncherCore.config.showDevTools && page.profile.config.dalamudEnabled } FormCard.FormComboBoxDelegate { id: dalamudInjectDelegate - visible: LauncherCore.config.showDevTools text: i18n("Injection Method") description: "It shouldn't be necessary to change this setting, unless you're running into issues injecting Dalamud." model: ["Entrypoint", "DLL Injection"] @@ -251,17 +252,18 @@ FormCard.FormCardPage { page.profile.config.save(); } enabled: page.profile.config.dalamudEnabled + visible: LauncherCore.config.showDevTools && page.profile.config.dalamudEnabled } FormCard.FormDelegateSeparator { above: dalamudInjectDelegate below: dalamudDelayDelegate + visible: LauncherCore.config.showDevTools && page.profile.config.dalamudEnabled } FormCard.FormSpinBoxDelegate { id: dalamudDelayDelegate - visible: LauncherCore.config.showDevTools label: i18n("Injection Delay") value: page.profile.config.dalamudInjectDelay onValueChanged: { @@ -269,14 +271,20 @@ FormCard.FormCardPage { page.profile.config.save(); } enabled: page.profile.config.dalamudEnabled + visible: LauncherCore.config.showDevTools && page.profile.config.dalamudEnabled } FormCard.FormDelegateSeparator { above: dalamudDelayDelegate + below: dalamudVersionTextDelegate + visible: page.profile.config.dalamudEnabled } FormCard.FormTextDelegate { + id: dalamudVersionTextDelegate + description: page.profile.dalamudVersionText + visible: page.profile.config.dalamudEnabled } }