redstrate/astra
1
Fork 0
mirror of https://github.com/redstrate/Astra.git synced 2025-04-20 11:47:46 +00:00
Code Activity

Modernize ProfileManager

Browse source
This commit is contained in:
Joshua Goins 2023-09-17 08:52:48 -04:00
parent 8d103c33d8
commit f990b9dd75
2 changed files with 10 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
launcher/include/profilemanager.h
View file

@ -23,11 +23,11 @@ public:
ProfileRole = Qt::UserRole, ProfileRole = Qt::UserRole,
}; };
int rowCount(const QModelIndex &index = QModelIndex()) const override; [[nodiscard]] int rowCount(const QModelIndex &index) const override;
QVariant data(const QModelIndex &index, int role) const override; [[nodiscard]] QVariant data(const QModelIndex &index, int role) const override;
QHash<int, QByteArray> roleNames() const override; [[nodiscard]] QHash<int, QByteArray> roleNames() const override;
Q_INVOKABLE Profile *getProfile(int index); Q_INVOKABLE Profile *getProfile(int index);
@ -35,7 +35,7 @@ public:
Q_INVOKABLE Profile *addProfile(); Q_INVOKABLE Profile *addProfile();
Q_INVOKABLE void deleteProfile(Profile *profile); Q_INVOKABLE void deleteProfile(Profile *profile);
QVector<Profile *> profiles() const; [[nodiscard]] QVector<Profile *> profiles() const;
Q_INVOKABLE bool canDelete(Profile *account) const; Q_INVOKABLE bool canDelete(Profile *account) const;

12
launcher/src/profilemanager.cpp
View file

@ -31,7 +31,7 @@ int ProfileManager::getProfileIndex(const QString &name)
Profile *ProfileManager::addProfile() Profile *ProfileManager::addProfile()
{ {
auto newProfile = new Profile(m_launcher, QUuid::createUuid().toString(), this); auto newProfile = new Profile(m_launcher, QUuid::createUuid().toString(), this);
newProfile->setName("New Profile"); newProfile->setName(QStringLiteral("New Profile"));
newProfile->readWineInfo(); newProfile->readWineInfo();
@ -45,7 +45,7 @@ Profile *ProfileManager::addProfile()
void ProfileManager::deleteProfile(Profile *profile) void ProfileManager::deleteProfile(Profile *profile)
{ {
auto config = KSharedConfig::openStateConfig(); auto config = KSharedConfig::openStateConfig();
config->deleteGroup(QString("profile-%1").arg(profile->uuid())); config->deleteGroup(QStringLiteral("profile-%1").arg(profile->uuid()));
config->sync(); config->sync();
const int row = m_profiles.indexOf(profile); const int row = m_profiles.indexOf(profile);
@ -61,7 +61,7 @@ QString ProfileManager::getDefaultWinePrefixPath()
#endif #endif
#if defined(Q_OS_LINUX) #if defined(Q_OS_LINUX)
return QDir::homePath() + "/.wine"; return QDir::homePath() + QStringLiteral("/.wine");
#endif #endif
return ""; return "";
@ -81,7 +81,7 @@ QString ProfileManager::getDefaultGamePath(const QString &uuid)
#if defined(Q_OS_LINUX) #if defined(Q_OS_LINUX)
const QDir appData = QStandardPaths::standardLocations(QStandardPaths::StandardLocation::AppDataLocation)[0]; const QDir appData = QStandardPaths::standardLocations(QStandardPaths::StandardLocation::AppDataLocation)[0];
const QDir gameDir = appData.absoluteFilePath("game"); const QDir gameDir = appData.absoluteFilePath(QStringLiteral("game"));
return gameDir.absoluteFilePath(uuid); return gameDir.absoluteFilePath(uuid);
#endif #endif
} }
@ -90,8 +90,8 @@ void ProfileManager::load()
{ {
auto config = KSharedConfig::openStateConfig(); auto config = KSharedConfig::openStateConfig();
for (const auto &id : config->groupList()) { for (const auto &id : config->groupList()) {
if (id.contains("profile-")) { if (id.contains(QLatin1String("profile-"))) {
auto profile = new Profile(m_launcher, QString(id).remove("profile-"), this); auto profile = new Profile(m_launcher, QString(id).remove(QLatin1String("profile-")), this);
insertProfile(profile); insertProfile(profile);
} }
} }