It turns out that Dalamud has it's own injector (since when??) and Astra
will now use that instead of my own solution. Thanks to marzent of the
XIV-on-Mac team, as that's how I learned this existed :-p
Not only does this remove quite a bit of code cruft, this should make
launching the game if you're using Dalamud more stable too :-)
Previously there was two separate auto-login functions, one in the cli
interface and one for the desktop interface. If I didn't stop myself,
there would probably be one in the tablet interface too!
* This uses the great libcotp library, I stripped it down to fit inside
the repository.
* This is a security-convenience trade-off, and it's made very clear
with the tooltips on the settings page.
* It's still secured by your system keychain, and it's up to the users
whether that's good enough for them. Eventually down the line
I would like to support more esoteric keychains such as Bitwarden or
KeePass.
* Right now it's only integrated into the auto-login desktop feature,
but there will eventually be like an "auto-fill OTP" button in the main
window.
There's still a lot to clean up with these new features but they work
a little at least :-)
Soon, you'll be able to store an OTP secret with Astra :-)
Also, the cancel button is broken ATM, so you have to manually turn the
feature off in the config.