From 1605098c2efe2d1d830889947f7682d54635b431 Mon Sep 17 00:00:00 2001 From: Joshua Goins Date: Sat, 10 May 2025 09:28:31 -0400 Subject: [PATCH] Update CONTRIBUTING to remind myself to update Icarus as needed --- CONTRIBUTING.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index fa7b4c1..84dced4 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -21,9 +21,10 @@ Here are the various things that should be checked when updating Kawari to a new * Bump the supported game versions in `lib.rs` so the patch server lets you through. * Double check IPC struct sizes in `calc_size()` if the structures changed. -* Replace testing data in `resources/tests` and re-run the tests. +* Replace testing data in `resources/tests` and re-run the tests as needed. * The IPC opcodes _will_ change and must all be replaced. -* Check the game version used in the encryption key in `lib.rs`. +* Check and update the various constants in `lib.rs`. +* If the Excel schema changed, update the Icarus version in `Cargo.toml`. ## IPC Opcodes