Run Clippy auto-fix, disable large enum size warning

src/bin/kawari-world.rs

@@ -11,16 +11,15 @@ use kawari::packet::{
     send_packet,
 };
 use kawari::world::ipc::{
-    ClientZoneIpcData, CommonSpawn, ContainerInfo, ContainerType, DisplayFlag,
+    ClientZoneIpcData, CommonSpawn, DisplayFlag, GameMasterCommandType, GameMasterRank, ObjectKind,
-    GameMasterCommandType, GameMasterRank, ItemInfo, ObjectKind, OnlineStatus, PlayerSubKind,
+    OnlineStatus, PlayerSubKind, ServerZoneIpcData, ServerZoneIpcSegment, ServerZoneIpcType,
-    ServerZoneIpcData, ServerZoneIpcSegment, ServerZoneIpcType, SocialListRequestType,
+    SocialListRequestType, StatusEffect,
-    StatusEffect,
 };
 use kawari::world::{
     ChatHandler, Inventory, Zone, ZoneConnection,
     ipc::{
-        ActorControl, ActorControlCategory, ActorControlSelf, PlayerEntry, PlayerSetup,
+        ActorControlCategory, ActorControlSelf, PlayerEntry, PlayerSetup, PlayerSpawn, PlayerStats,
-        PlayerSpawn, PlayerStats, SocialList,
+        SocialList,
     },
 };
 use kawari::world::{PlayerData, WorldDatabase};
@@ -781,7 +780,7 @@ async fn main() {
                                             "creating character from: {name} {chara_make_json}"
                                         );
 
-                                        let chara_make = CharaMake::from_json(&chara_make_json);
+                                        let chara_make = CharaMake::from_json(chara_make_json);
 
                                         let city_state =
                                             get_citystate(chara_make.classjob_id as u16);

src/lib.rs

@@ -1,5 +1,7 @@
 //! A server replacement for a certain MMO.
 
+#![allow(clippy::large_enum_variant)]
+
 use std::collections::HashMap;
 
 use minijinja::Environment;

src/login/database.rs

@@ -14,6 +14,12 @@ pub enum LoginError {
     InternalError,
 }
 
+impl Default for LoginDatabase {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl LoginDatabase {
     pub fn new() -> Self {
         let connection = Connection::open("login.db").expect("Failed to open database!");

src/packet/mod.rs

@@ -1,6 +1,6 @@
-mod packet;
+mod parsing;
-use packet::PacketHeader;
+use parsing::PacketHeader;
-pub use packet::{
+pub use parsing::{
     ConnectionType, PacketSegment, PacketState, SegmentType, parse_packet, send_keep_alive,
     send_packet,
 };

src/world/chat_handler.rs

@@ -1,11 +1,11 @@
 use crate::{
-    common::{CustomizeData, INVALID_OBJECT_ID, ObjectId, ObjectTypeId, Position, timestamp_secs},
+    common::{CustomizeData, ObjectId, ObjectTypeId, Position, timestamp_secs},
     config::get_config,
     packet::{PacketSegment, SegmentType},
     world::ipc::{
         ActorControl, ActorControlCategory, BattleNpcSubKind, CommonSpawn, DisplayFlag, NpcSpawn,
         ObjectKind, PlayerSpawn, PlayerSubKind, ServerZoneIpcData, ServerZoneIpcSegment,
-        ServerZoneIpcType, StatusEffectList,
+        ServerZoneIpcType,
     },
 };
 
@@ -135,7 +135,6 @@ impl ChatHandler {
                                 warp_finish_anim: 0x0,
                                 raise_anim: 0x0,
                             },
-                            ..Default::default()
                         }),
                     };
 

src/world/connection.rs

@@ -174,7 +174,7 @@ impl ZoneConnection {
     pub async fn send_inventory(&mut self) {
         // item list
         {
-            let equipped = self.inventory.equipped.clone();
+            let equipped = self.inventory.equipped;
 
             let mut send_slot = async |slot_index: u16, item: &Item| {
                 let ipc = ServerZoneIpcSegment {

src/world/database.rs

@@ -21,6 +21,12 @@ pub struct CharacterData {
     pub zone_id: u16,
 }
 
+impl Default for WorldDatabase {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl WorldDatabase {
     pub fn new() -> Self {
         let connection = Connection::open("world.db").expect("Failed to open database!");

src/world/inventory.rs

@@ -56,6 +56,12 @@ pub struct Inventory {
     pub equipped: EquippedContainer,
 }
 
+impl Default for Inventory {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl Inventory {
     pub fn new() -> Self {
         Self {

src/world/ipc/common_spawn.rs

@@ -3,8 +3,8 @@ use binrw::binrw;
 use bitflags::bitflags;
 
 use crate::common::{
-    CHAR_NAME_MAX_LENGTH, CustomizeData, INVALID_OBJECT_ID, ObjectId, ObjectTypeId, Position,
+    CHAR_NAME_MAX_LENGTH, CustomizeData, ObjectId, ObjectTypeId, Position, read_string,
-    read_string, write_string,
+    write_string,
 };
 
 use super::StatusEffect;