Fix more petty warnings

argcracker/src/main.cpp

@@ -18,7 +18,7 @@ inline char GetChecksum(unsigned int key)
 
 uint32_t TickCount();
 
-inline QString encryptGameArg(QString arg)
+inline QString encryptGameArg(const QString &arg)
 {
     unsigned int rawTicks = TickCount();
     unsigned int ticks = rawTicks & 0xFFFFFFFFu;

armoury/include/boneeditor.h

@@ -15,5 +15,5 @@ public:
     explicit BoneEditor(GearView *gearView, QWidget *parent = nullptr);
 
 private:
-    GearView *gearView;
+    GearView *gearView = nullptr;
 };

armoury/include/gearview.h

@@ -96,9 +96,9 @@ private:
 
     struct LoadedGear {
         GearInfo info;
-        physis_MDL mdl;
+        physis_MDL mdl{};
         QLatin1String path;
-        int bodyId;
+        int bodyId = 0;
     };
 
     std::vector<LoadedGear> loadedGears;

armoury/src/mainwindow.cpp

@@ -4,12 +4,10 @@
 #include "mainwindow.h"
 
 #include <QHBoxLayout>
-#include <QLineEdit>
 #include <QListWidget>
 #include <QTableWidget>
 #include <QTimer>
 
-#include <KAboutData>
 #include <QAction>
 #include <QApplication>
 #include <QDesktopServices>

common/include/vec3edit.h

@@ -13,7 +13,7 @@ class Vector3Edit : public QWidget
 
 public:
     explicit Vector3Edit(glm::vec3 &vec, QWidget *parent = nullptr);
-    ~Vector3Edit();
+    ~Vector3Edit() override;
 
     void setVector(glm::vec3 &vec);
 
@@ -22,9 +22,9 @@ Q_SIGNALS:
 
 private:
     struct {
-        QDoubleSpinBox *x, *y, *z;
+        QDoubleSpinBox *x = nullptr, *y = nullptr, *z = nullptr;
     } spinBoxes;
 
     glm::vec3 &vec;
-    QTimer *updateTimer;
+    QTimer *updateTimer = nullptr;
 };

extern/dxbc

@@ -1 +1 @@
-Subproject commit 190c185d983609b0887c5d2d8f0e8af84d507ee7
+Subproject commit 9db12735951da73adb2818c492ce70c80b663f75

parts/mdl/mdlimport.cpp

@@ -74,7 +74,7 @@ void importModel(physis_MDL &existingModel, const QString &filename)
                                                 + vertexAccessor.byteOffset);
 
                 // Replace position data
-                Vertex vertex;
+                Vertex vertex{};
                 if (i < existingModel.lods[lodNumber].parts[partNumber].num_vertices) {
                     vertex = existingModel.lods[lodNumber].parts[partNumber].vertices[i];
                 }

parts/mdl/vulkanwindow.h

@@ -13,9 +13,9 @@ class VulkanWindow : public QWindow
 public:
     VulkanWindow(MDLPart *part, Renderer *renderer, QVulkanInstance *instance);
 
-    void exposeEvent(QExposeEvent *);
+    void exposeEvent(QExposeEvent *) override;
 
-    bool event(QEvent *e);
+    bool event(QEvent *e) override;
 
     void render();
 

renderer/src/imguipass.h

@@ -7,7 +7,6 @@
 #include <vulkan/vulkan.h>
 
 class Renderer;
-struct RenderTarget;
 
 class ImGuiPass
 {

sagasu/include/mainwindow.h

@@ -18,8 +18,6 @@ public:
     MainWindow(const QString &gamePath, GameData *data);
 
 private:
-    QMdiArea *mdiArea = nullptr;
-
     GameData *data = nullptr;
     QTabWidget *partHolder = nullptr;
     FileCache fileCache;