From 4ca38efc575c4dd62322332d87308340bc9a7b8b Mon Sep 17 00:00:00 2001 From: Joshua Goins Date: Sun, 4 Feb 2024 15:16:18 -0500 Subject: [PATCH] karuku: Support localization --- karuku/src/main.cpp | 6 ++---- karuku/src/mainwindow.cpp | 17 +++++++++-------- karuku/src/sheetlistwidget.cpp | 3 ++- 3 files changed, 13 insertions(+), 13 deletions(-) diff --git a/karuku/src/main.cpp b/karuku/src/main.cpp index 602e4a2..d26a48f 100644 --- a/karuku/src/main.cpp +++ b/karuku/src/main.cpp @@ -1,6 +1,7 @@ // SPDX-FileCopyrightText: 2023 Joshua Goins // SPDX-License-Identifier: GPL-3.0-or-later +#include #include #include #include @@ -13,10 +14,7 @@ int main(int argc, char *argv[]) { QApplication app(argc, argv); - customizeAboutData(QStringLiteral("karuku"), - QStringLiteral("zone.xiv.karaku"), - QStringLiteral("Excel Editor"), - QStringLiteral("Program to view FFXIV Excel files.")); + customizeAboutData(QStringLiteral("karuku"), QStringLiteral("zone.xiv.karaku"), QStringLiteral("Excel Editor"), i18n("Program to view FFXIV Excel files.")); // Default to a sensible message pattern if (qEnvironmentVariableIsEmpty("QT_MESSAGE_PATTERN")) { diff --git a/karuku/src/mainwindow.cpp b/karuku/src/mainwindow.cpp index 44117c0..827f4b9 100644 --- a/karuku/src/mainwindow.cpp +++ b/karuku/src/mainwindow.cpp @@ -3,6 +3,7 @@ #include "mainwindow.h" +#include #include #include #include @@ -80,10 +81,10 @@ static bool copyDirectory(const QString &srcFilePath, const QString &tgtFilePath void MainWindow::setupFileMenu(QMenu *menu) { - auto openList = menu->addAction(QStringLiteral("Import Definitions...")); + auto openList = menu->addAction(i18nc("@action:inmenu", "Import Definitions...")); openList->setIcon(QIcon::fromTheme(QStringLiteral("document-open"))); connect(openList, &QAction::triggered, [this] { - auto fileName = QFileDialog::getExistingDirectory(nullptr, QStringLiteral("Open Defintions Directory"), QStringLiteral("~")); + auto fileName = QFileDialog::getExistingDirectory(nullptr, i18nc("@title:window", "Open Defintions Directory"), QStringLiteral("~")); const QDir dataDir = QStandardPaths::writableLocation(QStandardPaths::AppDataLocation); const QDir definitionsDir = dataDir.absoluteFilePath(QStringLiteral("definitions")); @@ -97,17 +98,17 @@ void MainWindow::setupFileMenu(QMenu *menu) copyDirectory(fileName, definitionsDir.absolutePath()); - QMessageBox::information(this, QStringLiteral("Definitions"), QStringLiteral("Successfully imported definitions!")); + QMessageBox::information(this, i18nc("@title:window", "Definitions"), i18n("Successfully imported definitions!")); }); - auto downloadList = menu->addAction(QStringLiteral("Download Definitions...")); + auto downloadList = menu->addAction(i18nc("@action:inmenu", "Download Definitions...")); downloadList->setIcon(QIcon::fromTheme(QStringLiteral("download-symbolic"))); connect(downloadList, &QAction::triggered, [this] { const int ret = QMessageBox::information(this, - QStringLiteral("Download Confirmation"), - QStringLiteral("This will download the definitions from the SaintCoinach repository on GitHub.

Continue?"), + i18nc("@title:window", "Download Confirmation"), + i18n("This will download the definitions from the SaintCoinach repository on GitHub.

Continue?"), QMessageBox::Ok | QMessageBox::Cancel, QMessageBox::Ok); @@ -155,7 +156,7 @@ void MainWindow::setupFileMenu(QMenu *menu) archive.close(); - QMessageBox::information(this, QStringLiteral("Definitions"), QStringLiteral("Successfully downloaded and imported definitions!")); + QMessageBox::information(this, i18nc("@title:window", "Definitions"), i18n("Successfully downloaded and imported definitions!")); }); }); } diff --git a/karuku/src/sheetlistwidget.cpp b/karuku/src/sheetlistwidget.cpp index c4dc652..7ec9476 100644 --- a/karuku/src/sheetlistwidget.cpp +++ b/karuku/src/sheetlistwidget.cpp @@ -3,6 +3,7 @@ #include "sheetlistwidget.h" +#include #include #include #include @@ -22,7 +23,7 @@ SheetListWidget::SheetListWidget(GameData *data, QWidget *parent) searchModel->setFilterCaseSensitivity(Qt::CaseSensitivity::CaseInsensitive); auto searchEdit = new QLineEdit(); - searchEdit->setPlaceholderText(QStringLiteral("Search...")); + searchEdit->setPlaceholderText(i18nc("@info:placeholder", "Search…")); searchEdit->setClearButtonEnabled(true); searchEdit->setProperty("_breeze_borders_sides", QVariant::fromValue(QFlags{Qt::BottomEdge})); connect(searchEdit, &QLineEdit::textChanged, this, [=](const QString &text) {