redstrate/novus
1
Fork 0
mirror of https://github.com/redstrate/Novus.git synced 2025-04-25 21:27:45 +00:00
Code Activity

Fix accidental double bitangent handedness multiplication

Browse source
This commit is contained in:
Joshua Goins 2024-01-29 17:41:34 -05:00
parent efaddd4861
commit 605e2f7e60
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
parts/mdl/mdlimport.cpp
View file

@ -144,9 +144,9 @@ void importModel(physis_MDL &existingModel, const QString &filename)
// calculate binormal, because glTF won't give us those!!
const glm::vec3 normal = glm::vec3(vertex.normal[0], vertex.normal[1], vertex.normal[2]);
const glm::vec4 tangent = *tangent1Data;
const glm::vec3 bitangent = glm::normalize(glm::cross(normal, glm::vec3(tangent)) * tangent.w);
const glm::vec3 bitangent = glm::normalize(glm::cross(normal, glm::vec3(tangent)));
const float handedness = glm::dot(glm::cross(glm::vec3(tangent), bitangent), normal) > 0 ? 1 : -1;
const float handedness = tangent.w;
// In a cruel twist of fate, Tangent1 is actually the **BINORMAL** and not the tangent data. Square Enix is AMAZING.
vertex.bitangent[0] = bitangent.x * handedness;