Use a proper export header

CMakeLists.txt

@@ -25,6 +25,7 @@ include(KDEGitCommitHooks)
 include(KDEClangFormat)
 include(FeatureSummary)
 include(FetchContent)
+include(ECMGenerateExportHeader)
 
 ecm_setup_version(${PROJECT_VERSION}
         VARIABLE_PREFIX NOVUS

common/CMakeLists.txt

@@ -2,7 +2,6 @@
 # SPDX-License-Identifier: CC0-1.0
 
 if (WIN32)
-    set(CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS ON)
     add_library(novus-common SHARED)
 else()
     add_library(novus-common STATIC)
@@ -40,6 +39,15 @@ target_link_libraries(novus-common
         Qt6::Widgets
         glm::glm)
 target_compile_definitions(novus-common PRIVATE TRANSLATION_DOMAIN="novus")
+set_target_properties(novus-common PROPERTIES
+        EXPORT_NAME NovusCommon
+)
+ecm_generate_export_header(novus-common
+        BASE_NAME NovusCommon
+        VERSION 1.0.0
+)
+
+target_include_directories(novus-common PUBLIC "$<BUILD_INTERFACE:${novus-common_INCLUDE_DIRS}>")
 
 add_library(Novus::Common ALIAS novus-common)
 

common/include/aboutdata.h

@@ -6,4 +6,7 @@
 #include <KAboutData>
 #include <QString>
 
-void customizeAboutData(const QString &componentName, const QString &desktopFilename, const QString &applicationTitle, const QString &applicationDescription);
+#include "novuscommon_export.h"
+
+NOVUSCOMMON_EXPORT void
+customizeAboutData(const QString &componentName, const QString &desktopFilename, const QString &applicationTitle, const QString &applicationDescription);

common/include/filecache.h

@@ -9,9 +9,11 @@
 #include <QString>
 #include <physis.hpp>
 
+#include "novuscommon_export.h"
+
 struct GameData;
 
-class FileCache
+class NOVUSCOMMON_EXPORT FileCache
 {
 public:
     explicit FileCache(GameData &data);

common/include/filetypes.h

@@ -5,9 +5,11 @@
 
 #include <QString>
 
+#include "novuscommon_export.h"
+
 enum class FileType { Unknown, ExcelList, ExcelHeader, ExcelData, Model, Texture, ShaderPackage, CharaMakeParams, Skeleton, Dictionary };
 
-class FileTypes
+class NOVUSCOMMON_EXPORT FileTypes
 {
 public:
     static FileType getFileType(const QString &extension);

common/include/novusmainwindow.h

@@ -5,7 +5,9 @@
 
 #include <QMainWindow>
 
-class NovusMainWindow : public QMainWindow
+#include "novuscommon_export.h"
+
+class NOVUSCOMMON_EXPORT NovusMainWindow : public QMainWindow
 {
 public:
     explicit NovusMainWindow();

common/include/quaternionedit.h

@@ -8,7 +8,9 @@
 
 #include <glm/glm.hpp>
 
-class QuaternionEdit : public QWidget
+#include "novuscommon_export.h"
+
+class NOVUSCOMMON_EXPORT QuaternionEdit : public QWidget
 {
     Q_OBJECT
 

common/include/settings.h

@@ -5,4 +5,6 @@
 
 #include <QString>
 
-QString getGameDirectory();
+#include "novuscommon_export.h"
+
+NOVUSCOMMON_EXPORT QString getGameDirectory();

common/include/vec3edit.h

@@ -7,7 +7,9 @@
 #include <QWidget>
 #include <glm/glm.hpp>
 
-class Vector3Edit : public QWidget
+#include "novuscommon_export.h"
+
+class NOVUSCOMMON_EXPORT Vector3Edit : public QWidget
 {
     Q_OBJECT