redstrate/physis
1
Fork 0
mirror of https://github.com/redstrate/Physis.git synced 2025-05-18 16:07:46 +00:00
Code Activity

Make indice reading (for models) slightly faster

Browse source 
As suspected - this was a little slow, and can be corroborated with
Hotspot. This is only a marginal increase in performance, it isn't huge
but still worth doing.
This commit is contained in:
Joshua Goins 2025-05-17 10:22:27 -04:00
parent 39f1c9665f
commit f58d4e6bb0
1 changed files with 5 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/model/mod.rs
View file

@ -10,8 +10,8 @@ pub mod vertex_declarations;
use std::io::{Cursor, Seek, SeekFrom};
use std::mem::size_of;
use binrw::BinRead;
use binrw::BinReaderExt;
use binrw::{BinRead, VecArgs};
use binrw::{BinWrite, BinWriterExt, binrw};
use crate::common_file_operations::{read_bool_from, write_bool_as};
@ -694,12 +694,10 @@ impl MDL {
))
.ok()?;
// TODO: optimize!
let mut indices: Vec<u16> =
Vec::with_capacity(model.meshes[j as usize].index_count as usize);
for _ in 0..model.meshes[j as usize].index_count {
indices.push(cursor.read_le::<u16>().ok()?);
}
let index_count = model.meshes[j as usize].index_count as usize;
let indices: Vec<u16> = cursor
.read_le_args(VecArgs::builder().count(index_count).finalize())
.ok()?;
let mut submeshes: Vec<SubMesh> =
Vec::with_capacity(model.meshes[j as usize].submesh_count as usize);