From 4d9a333781843543d7ea0d5d1fb7f0c4035aca1b Mon Sep 17 00:00:00 2001 From: Joshua Goins Date: Mon, 21 Feb 2022 00:14:12 -0500 Subject: [PATCH] Remove, cleanup some constructors --- engine/renderer/include/shadowpass.hpp | 4 ++-- engine/renderer/include/smaapass.hpp | 2 +- engine/shadercompiler/include/shadercompiler.hpp | 1 - tools/common/include/undostack.hpp | 2 -- 4 files changed, 3 insertions(+), 6 deletions(-) diff --git a/engine/renderer/include/shadowpass.hpp b/engine/renderer/include/shadowpass.hpp index e4156ec..c72bda0 100755 --- a/engine/renderer/include/shadowpass.hpp +++ b/engine/renderer/include/shadowpass.hpp @@ -17,14 +17,14 @@ struct CameraFrustum; class ShadowPass { public: - ShadowPass(GFX* gfx); + explicit ShadowPass(GFX* gfx); void create_scene_resources(Scene& scene); void render(GFXCommandBuffer* command_buffer, Scene& scene); private: - void render_meshes(GFXCommandBuffer* command_buffer, Scene& scene, const Matrix4x4 light_matrix, const Matrix4x4 model, const prism::float3 light_position, const Light::Type type, const CameraFrustum& frustum, const int base_instance); + void render_meshes(GFXCommandBuffer* command_buffer, Scene& scene, Matrix4x4 light_matrix, Matrix4x4 model, prism::float3 light_position, Light::Type type, const CameraFrustum& frustum, int base_instance); void render_sun(GFXCommandBuffer* command_buffer, Scene& scene, prism::Object light_object, Light& light); void render_spot(GFXCommandBuffer* command_buffer, Scene& scene, prism::Object light_object, Light& light); diff --git a/engine/renderer/include/smaapass.hpp b/engine/renderer/include/smaapass.hpp index df29d1c..f22608f 100755 --- a/engine/renderer/include/smaapass.hpp +++ b/engine/renderer/include/smaapass.hpp @@ -17,7 +17,7 @@ namespace prism { class SMAAPass { public: - SMAAPass(GFX* gfx); + explicit SMAAPass(GFX* gfx); void create_render_target_resources(RenderTarget& target); diff --git a/engine/shadercompiler/include/shadercompiler.hpp b/engine/shadercompiler/include/shadercompiler.hpp index fec5981..e8dea63 100755 --- a/engine/shadercompiler/include/shadercompiler.hpp +++ b/engine/shadercompiler/include/shadercompiler.hpp @@ -44,7 +44,6 @@ public: class ShaderSource { public: ShaderSource() : source(std::monostate()) {} - ShaderSource(const ShaderSource& rhs) : source (rhs.source) {} explicit ShaderSource(const std::string& source_string) : source(source_string) {} explicit ShaderSource(const std::vector& source_bytecode) : source(source_bytecode) {} explicit ShaderSource(const prism::path& shader_path) : source(shader_path) {} diff --git a/tools/common/include/undostack.hpp b/tools/common/include/undostack.hpp index 543074c..c192876 100755 --- a/tools/common/include/undostack.hpp +++ b/tools/common/include/undostack.hpp @@ -6,8 +6,6 @@ class Command { public: - virtual ~Command() {} - std::string stored_name; std::string get_name() {