mirror of
https://github.com/SapphireServer/Sapphire.git
synced 2025-05-05 10:17:46 +00:00
Potential Truncation - value over signed char
In PacketHandlers.cpp ~line453 - we are trying to insert a hex value (128) x80 and will cause an underflow to -128. Suggestion is to move to unsigned char to capture the intended value.
This commit is contained in:
parent
7f48f567a3
commit
238a1c17a6
1 changed files with 1 additions and 1 deletions
|
@ -81,7 +81,7 @@ struct FFXIVIpcPlayTime : FFXIVIpcBasePacket<Playtime>
|
|||
*/
|
||||
struct PlayerEntry {
|
||||
uint64_t contentId;
|
||||
char bytes[12];
|
||||
unsigned char bytes[12];
|
||||
uint16_t zoneId;
|
||||
uint16_t zoneId1;
|
||||
char bytes1[8];
|
||||
|
|
Loading…
Add table
Reference in a new issue